Make interactive snapshot output a bit more obvious #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing this change revealed a bug in `test_code()`: specifying the default reporter happened _after_ `local_test_context()` meaning that it failed to capture the actual user settings. I fixed this by now requiring a reporter (rather than a backup reporter). Fixes #1992
|
As well as the test failure, I also need to add a news bullet. |
DavisVaughan
approved these changes
Oct 31, 2024
Co-authored-by: Davis Vaughan <[email protected]>
|
I think this looks nice now, not sure about your test failure though 
|
|
@DavisVaughan can you take one more look please? |
DavisVaughan
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing this change revealed a bug in
test_code(): specifying the default reporter happened afterlocal_test_context()meaning that it failed to capture the actual user settings. I fixed this by now requiring a reporter (rather than a backup reporter).Fixes #1992
@DavisVaughan I can't figure out how to test this, so you might want to run a few snapshot tests interactively (both inside of
test_that()and directly).